Field batch 4: deferred routines of batch 3 and the next field order

Gatchan commented

2026-11-05 06:53:44 +00:00

Owner

Continue the field port after #56 (PR #57), same method and validation (draftc -> draft_check -> naming/restructuring -> portbridge -> groundtruth + shadow on the 5 routes US/JP, fuzz, instruction coverage, portstyle, debug/clang -LE slow).

Routines deferred by batch 3: MoveObjs, _c0714a, LoadLetterGfx, UpdateDlgWindow, UpdateSpotlights, CheckCollosions, TfrDlgTextGfx, TfrDlgCursorGfx, ClearDlgTextRegion (second DMA upload style), DrawTimer (divider, now compared by #58). Then the next routines of docs/coverage.md field order, up to about 30 routines. Frame-crossing routines are skipped (#37); every skip is listed with its reason. Original bugs found go to re/known-bugs.toml.

Continue the field port after #56 (PR #57), same method and validation (draftc -> draft_check -> naming/restructuring -> portbridge -> groundtruth + shadow on the 5 routes US/JP, fuzz, instruction coverage, portstyle, debug/clang `-LE slow`). Routines deferred by batch 3: MoveObjs, _c0714a, LoadLetterGfx, UpdateDlgWindow, UpdateSpotlights, CheckCollosions, TfrDlgTextGfx, TfrDlgCursorGfx, ClearDlgTextRegion (second DMA upload style), DrawTimer (divider, now compared by #58). Then the next routines of docs/coverage.md field order, up to about 30 routines. Frame-crossing routines are skipped (#37); every skip is listed with its reason. Original bugs found go to re/known-bugs.toml.

Gatchan referenced this issue from a commit

2026-11-05 15:11:27 +00:00

tools: portbridge --db-inside for routines that set DB between hardware and high WRAM accesses; coverage_report --order (all modules) and --reached (refs #59)

Gatchan referenced this issue from a commit

2026-11-05 15:11:27 +00:00

hw: upload styles selected by the bridges (HW_UPLOAD_FIELD_TEXT), vid_clear_tiles (refs #59)

Gatchan referenced this issue from a commit

2026-11-05 15:11:27 +00:00

state: RAM map and resources for field batch 4 (dialog uploads, letter, object list and collisions, window 2 HDMA; large_font_gfx, map_sprite_pal, map_pal) (refs #59)

Gatchan referenced this issue from a commit

2026-11-05 15:11:27 +00:00

port: field batch 4, 20 routines (TfrDlgTextGfx, TfrDlgCursorGfx, ClearDlgTextRegion, DrawTimer, LoadLetterGfx, MoveObjs, _c0714a, CheckCollosions, IncPalAnimCounter, InitSpritePal, ResetSprites, CalcObjPtrs, InitObjAnim, IncObjScriptPtr, BGColorInc, BGColorUnInc, LoadMapPal, UpdateObjLayerPriorityBefore, CalcObjMoveDir, InitWindowHDMAData) (shadow chapter 1 routes 0/1866252 US, 0/1694094 JP, 0 fallback; fuzz 0 mismatch) (refs #59)

Gatchan referenced this issue from a pull request that will close it,

2026-11-05 15:11:40 +00:00

Field batch 4: 20 chapter 1 routines (fixes #59) #62

Gatchan closed this issue

2026-11-05 15:11:43 +00:00

Gatchan referenced this issue from a commit

2026-11-05 15:11:43 +00:00

Merge pull request 'Field batch 4: 20 chapter 1 routines (fixes #59)' (#62) from field-batch4 into main

Gatchan commented

2026-11-05 15:11:52 +00:00

Author

Owner

Merged in PR #62: 20 chapter 1 field routines. Shadow on the chapter 1 routes, 66 ports: US 1 866 252 calls, JP 1 694 094, 0 mismatch, 0 fallback; fuzz 0 mismatch; instructions US 1165/1205, JP 1021/1205; debug/clang ctest -LE slow 27/27. Skips listed in docs/ports.md.

Rows
Columns

Field batch 4: deferred routines of batch 3 and the next field order #59